Security Audit Report: Reentrancy & Access Control Review: ether.fi Stake

The ether.fi Stake liquid staking protocol manages large amounts of assets and faces significant security risks. Our review identified multiple vulnerabilities, primarily reentrancy and access control issues that could allow an attacker to drain billions of dollars in user deposits.

The audit focused on the deposit/withdrawal flow, reward distribution, cross-chain bridge interactions, and the protocol's admin controls. Key findings reveal:

1. A critical reentrancy flaw in the cross-chain withdrawal mechanism where an attacker could exploit the external bridge call to double-draw funds.

2. Improper use of tx.origin for admin access checks that could be bypassed by malicious contracts, granting attackers full control over protocol parameters.

3. Missing nonReentrant checks in the reward claim function, enabling reentrancy attacks on the RewardDistributor contract.

4. The upgradeable proxy admin is exposed without proper time-locks, allowing rapid, unvetted contract upgrades.

5. Unrestricted fee rate adjustments protected only by the same flawed ownership check.

6. Lack of input validation for message IDs stored by the L2 bridge, which could lead to reward double-credits.

7. Missing events for important state-changing functions that reduce on-chain visibility of protocol actions.

The most pressing risk is the reentrancy surface in the withdrawal process, particularly when interacting with potentially malicious L2 bridge contracts. Access control weaknesses, especially the tx.origin check, compound the danger by enabling attacker takeovers of protocol controls. Overall, addressing these issues is critical to preventing the potential multi-hundred million dollar losses that such vulnerabilities could cause.